Commit e1364711 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix illegal memory access on Abort IOCBs 

In devloss timer handler and in backend calls to terminate remote port I/O,
there is logic to walk through all active IOCBs and validate them to
potentially trigger an abort request. This logic is causing illegal memory
accesses which leads to a crash. Abort IOCBs, which may be on the list, do
not have an associated lpfc_io_buf struct. The driver is trying to map an
lpfc_io_buf struct on the IOCB and which results in a bogus address thus
the issue.

Fix by skipping over ABORT IOCBs (CLOSE IOCBs are ABORTS that don't send
ABTS) in the IOCB scan logic.

Link: https://lore.kernel.org/r/20210421234433.102079-1-jsmart2021@gmail.com


Co-developed-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 85367040

drivers/scsi/lpfc/lpfc_sli.c

+9 −2
Original line number Diff line number Diff line
@@ -11804,13 +11804,20 @@ lpfc_sli_validate_fcp_iocb(struct lpfc_iocbq *iocbq, struct lpfc_vport *vport, 
			   lpfc_ctx_cmd ctx_cmd)

{

	struct lpfc_io_buf *lpfc_cmd;

	IOCB_t *icmd = NULL;

	int rc = 1;









	if (!iocbq || iocbq->vport != vport)









		return rc;

















	if (!(iocbq->iocb_flag & LPFC_IO_FCP) ||









	    !(iocbq->iocb_flag & LPFC_IO_ON_TXCMPLQ))









	    !(iocbq->iocb_flag & LPFC_IO_ON_TXCMPLQ) ||









	      iocbq->iocb_flag & LPFC_DRIVER_ABORTED)









		return rc;

















	icmd = &iocbq->iocb;









	if (icmd->ulpCommand == CMD_ABORT_XRI_CN ||









	    icmd->ulpCommand == CMD_CLOSE_XRI_CN)









		return rc;

















	lpfc_cmd = container_of(iocbq, struct lpfc_io_buf, cur_iocbq);