Unverified Commit e12ff287 authored by Maxime Chevallier's avatar Maxime Chevallier Committed by Mark Brown
Browse files

regmap: mmio: Allow passing an empty config->reg_stride 



Regmap's stride is used for MMIO regmaps to check the correctness of
reg_width. However, it's acceptable to pass an empty config->reg_stride,
in that case the actual stride used is 1.

There are valid cases now to pass an empty stride, when using
down/upshifting of register address. In this case, the stride value
loses its sense, so ignore the reg_width when the stride isn't set.

Signed-off-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://lore.kernel.org/r/20230511142735.316445-1-maxime.chevallier@bootlin.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f33a751d

drivers/base/regmap/regmap-mmio.c

+1 −1
Original line number Diff line number Diff line
@@ -448,7 +448,7 @@ static struct regmap_mmio_context *regmap_mmio_gen_context(struct device *dev, 
	if (min_stride < 0)

		return ERR_PTR(min_stride);



	if (config->reg_stride < min_stride)

	if (config->reg_stride && config->reg_stride < min_stride)

		return ERR_PTR(-EINVAL);



	if (config->use_relaxed_mmio && config->io_port)