Commit e127fafd authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Dave Chinner
Browse files

xfs: remove unnecessary parentheses from log redo item recovery functions 



Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent 722e2517

fs/xfs/xfs_extfree_item.c

+6 −6
Original line number Diff line number Diff line
@@ -515,13 +515,13 @@ xfs_efi_recover( 
	 * just toss the EFI.

	 */

	for (i = 0; i < efip->efi_format.efi_nextents; i++) {

		extp = &(efip->efi_format.efi_extents[i]);

		extp = &efip->efi_format.efi_extents[i];

		startblock_fsb = XFS_BB_TO_FSB(mp,

				   XFS_FSB_TO_DADDR(mp, extp->ext_start));

		if ((startblock_fsb == 0) ||

		    (extp->ext_len == 0) ||

		    (startblock_fsb >= mp->m_sb.sb_dblocks) ||

		    (extp->ext_len >= mp->m_sb.sb_agblocks)) {

		if (startblock_fsb == 0 ||

		    extp->ext_len == 0 ||

		    startblock_fsb >= mp->m_sb.sb_dblocks ||

		    extp->ext_len >= mp->m_sb.sb_agblocks) {

			/*

			 * This will pull the EFI from the AIL and

			 * free the memory associated with it.
@@ -539,7 +539,7 @@ xfs_efi_recover( 


	xfs_rmap_skip_owner_update(&oinfo);

	for (i = 0; i < efip->efi_format.efi_nextents; i++) {

		extp = &(efip->efi_format.efi_extents[i]);

		extp = &efip->efi_format.efi_extents[i];

		error = xfs_trans_free_extent(tp, efdp, extp->ext_start,

					      extp->ext_len, &oinfo);

		if (error)

fs/xfs/xfs_rmap_item.c

+6 −6
Original line number Diff line number Diff line
@@ -454,7 +454,7 @@ xfs_rui_recover( 
	 * just toss the RUI.

	 */

	for (i = 0; i < ruip->rui_format.rui_nextents; i++) {

		rmap = &(ruip->rui_format.rui_extents[i]);

		rmap = &ruip->rui_format.rui_extents[i];

		startblock_fsb = XFS_BB_TO_FSB(mp,

				   XFS_FSB_TO_DADDR(mp, rmap->me_startblock));

		switch (rmap->me_flags & XFS_RMAP_EXTENT_TYPE_MASK) {
@@ -469,10 +469,10 @@ xfs_rui_recover( 
			op_ok = false;

			break;

		}

		if (!op_ok || (startblock_fsb == 0) ||

		    (rmap->me_len == 0) ||

		    (startblock_fsb >= mp->m_sb.sb_dblocks) ||

		    (rmap->me_len >= mp->m_sb.sb_agblocks) ||

		if (!op_ok || startblock_fsb == 0 ||

		    rmap->me_len == 0 ||

		    startblock_fsb >= mp->m_sb.sb_dblocks ||

		    rmap->me_len >= mp->m_sb.sb_agblocks ||

		    (rmap->me_flags & ~XFS_RMAP_EXTENT_FLAGS)) {

			/*

			 * This will pull the RUI from the AIL and
@@ -490,7 +490,7 @@ xfs_rui_recover( 
	rudp = xfs_trans_get_rud(tp, ruip);



	for (i = 0; i < ruip->rui_format.rui_nextents; i++) {

		rmap = &(ruip->rui_format.rui_extents[i]);

		rmap = &ruip->rui_format.rui_extents[i];

		state = (rmap->me_flags & XFS_RMAP_EXTENT_UNWRITTEN) ?

				XFS_EXT_UNWRITTEN : XFS_EXT_NORM;

		whichfork = (rmap->me_flags & XFS_RMAP_EXTENT_ATTR_FORK) ?