Commit e11e285b authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: edif: Fix off by one bug in qla_edif_app_getfcinfo() 

The > comparison needs to be >= to prevent accessing one element beyond the
end of the app_reply->ports[] array.

Link: https://lore.kernel.org/r/20211109115219.GE16587@kili


Fixes: 7878f22a ("scsi: qla2xxx: edif: Add getfcinfo and statistic bsgs")
Reviewed-by: default avatarEwan D. Milne <emilne@redhat.com>
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 73185a13

drivers/scsi/qla2xxx/qla_edif.c

+1 −1
Original line number Diff line number Diff line
@@ -865,7 +865,7 @@ qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job) 
			    "APP request entry - portid=%06x.\n", tdid.b24);



			/* Ran out of space */

			if (pcnt > app_req.num_ports)

			if (pcnt >= app_req.num_ports)

				break;



			if (tdid.b24 != 0 && tdid.b24 != fcport->d_id.b24)