Commit e112c413 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Peter Zijlstra
Browse files

futex: Prepare futex_lock_pi() for runtime clock selection 



futex_lock_pi() is the only futex operation which cannot select the clock
for timeouts (CLOCK_MONOTONIC/CLOCK_REALTIME). That's inconsistent and
there is no particular reason why this cannot be supported.

This was overlooked when CLOCK_REALTIME_FLAG was introduced and
unfortunately not reported when the inconsistency was discovered in glibc.

Prepare the function and enforce the CLOCK_REALTIME_FLAG on FUTEX_LOCK_PI
so that a new FUTEX_LOCK_PI2 can implement it correctly.

Reported-by: default avatarKurt Kanzenbach <kurt@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210422194705.338657741@linutronix.de
parent 1a812296

kernel/futex.c

+2 −1
Original line number Diff line number Diff line
@@ -2783,7 +2783,7 @@ static int futex_lock_pi(u32 __user *uaddr, unsigned int flags, 
	if (refill_pi_state_cache())

		return -ENOMEM;



	to = futex_setup_timer(time, &timeout, FLAGS_CLOCKRT, 0);

	to = futex_setup_timer(time, &timeout, flags, 0);



retry:

	ret = get_futex_key(uaddr, flags & FLAGS_SHARED, &q.key, FUTEX_WRITE);
@@ -3739,6 +3739,7 @@ long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout, 
	case FUTEX_WAKE_OP:

		return futex_wake_op(uaddr, flags, uaddr2, val, val2, val3);

	case FUTEX_LOCK_PI:

		flags |= FLAGS_CLOCKRT;

		return futex_lock_pi(uaddr, flags, timeout, 0);

	case FUTEX_UNLOCK_PI:

		return futex_unlock_pi(uaddr, flags);