Commit e0fccdaf authored by Logan Gunthorpe's avatar Logan Gunthorpe Committed by Jens Axboe
Browse files

md/raid5-ppl: Drop unused argument from ppl_handle_flush_request() 



ppl_handle_flush_request() takes an struct r5log argument but doesn't
use it. It has no buisiness taking this argument as it is only used
by raid5-cache and has no way to derference it anyway. Remove
the argument.

No functional changes intended.

Signed-off-by: default avatarLogan Gunthorpe <logang@deltatee.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarSong Liu <song@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent ed0c6a5f

drivers/md/raid5-log.h

+2 −2
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ void ppl_write_stripe_run(struct r5conf *conf); 
void ppl_stripe_write_finished(struct stripe_head *sh);

int ppl_modify_log(struct r5conf *conf, struct md_rdev *rdev, bool add);

void ppl_quiesce(struct r5conf *conf, int quiesce);

int ppl_handle_flush_request(struct r5l_log *log, struct bio *bio);

int ppl_handle_flush_request(struct bio *bio);

extern struct md_sysfs_entry ppl_write_hint;



static inline bool raid5_has_log(struct r5conf *conf)
@@ -108,7 +108,7 @@ static inline int log_handle_flush_request(struct r5conf *conf, struct bio *bio) 
	if (conf->log)

		ret = r5l_handle_flush_request(conf->log, bio);

	else if (raid5_has_ppl(conf))

		ret = ppl_handle_flush_request(conf->log, bio);

		ret = ppl_handle_flush_request(bio);



	return ret;

}

drivers/md/raid5-ppl.c

+1 −1
Original line number Diff line number Diff line
@@ -679,7 +679,7 @@ void ppl_quiesce(struct r5conf *conf, int quiesce) 
	}

}



int ppl_handle_flush_request(struct r5l_log *log, struct bio *bio)

int ppl_handle_flush_request(struct bio *bio)

{

	if (bio->bi_iter.bi_size == 0) {

		bio_endio(bio);