Commit e0f3907b authored by Vincent Mailhol's avatar Vincent Mailhol Committed by Marc Kleine-Budde
Browse files

can: etas_es58x: remove useless calls to usb_fill_bulk_urb() 



Aside of urb->transfer_buffer_length and urb->context which might
change in the TX path, all the other URB parameters remains constant
during runtime. So, there is no reasons to call usb_fill_bulk_urb()
each time before submitting an URB.

Make sure to initialize all the fields of the URB at allocation
time. For the TX branch, replace the call usb_fill_bulk_urb() by an
assignment of urb->context. urb->urb->transfer_buffer_length is
already set by the caller functions, no need to set it again. For the
RX branch, because all parameters are unchanged, simply remove the
call to usb_fill_bulk_urb().

Signed-off-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
Link: https://lore.kernel.org/all/20220729080902.25839-1-mailhol.vincent@wanadoo.fr


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 12a18d79

drivers/net/can/usb/etas_es58x/es58x_core.c

+3 −8
Original line number Diff line number Diff line
@@ -1460,10 +1460,6 @@ static void es58x_read_bulk_callback(struct urb *urb) 
	}



 resubmit_urb:

	usb_fill_bulk_urb(urb, es58x_dev->udev, es58x_dev->rx_pipe,

			  urb->transfer_buffer, urb->transfer_buffer_length,

			  es58x_read_bulk_callback, es58x_dev);



	ret = usb_submit_urb(urb, GFP_ATOMIC);

	if (ret == -ENODEV) {

		for (i = 0; i < es58x_dev->num_can_ch; i++)
@@ -1597,7 +1593,8 @@ static struct urb *es58x_get_tx_urb(struct es58x_device *es58x_dev) 
			return NULL;



		usb_fill_bulk_urb(urb, es58x_dev->udev, es58x_dev->tx_pipe,

				  buf, tx_buf_len, NULL, NULL);

				  buf, tx_buf_len, es58x_write_bulk_callback,

				  NULL);

		return urb;

	}
@@ -1630,9 +1627,7 @@ static int es58x_submit_urb(struct es58x_device *es58x_dev, struct urb *urb, 
	int ret;



	es58x_set_crc(urb->transfer_buffer, urb->transfer_buffer_length);

	usb_fill_bulk_urb(urb, es58x_dev->udev, es58x_dev->tx_pipe,

			  urb->transfer_buffer, urb->transfer_buffer_length,

			  es58x_write_bulk_callback, netdev);

	urb->context = netdev;

	usb_anchor_urb(urb, &es58x_dev->tx_urbs_busy);

	ret = usb_submit_urb(urb, GFP_ATOMIC);

	if (ret) {