Commit e0d43ed6 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Li Yang
Browse files

bus: fsl-mc: fsl-mc-allocator: Initialize mc_bus_dev before use 



Fixes a clang compiler warning:

>> drivers/bus/fsl-mc/fsl-mc-allocator.c:108:12: warning: variable 'mc_bus_dev' is uninitialized when used here [-Wuninitialized]
                   dev_err(&mc_bus_dev->dev, "resource mismatch\n");

Fixes: b3134039 ("bus: fsl-mc: fsl-mc-allocator: Improve error reporting")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306021936.OktTcMAT-lkp@intel.com/


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarLi Yang <leoyang.li@nxp.com>
parent 7b1a78ba

drivers/bus/fsl-mc/fsl-mc-allocator.c

+3 −2
Original line number Diff line number Diff line
@@ -103,14 +103,15 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device 
	struct fsl_mc_resource *resource;

	int error = -EINVAL;



	mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent);

	mc_bus = to_fsl_mc_bus(mc_bus_dev);



	resource = mc_dev->resource;

	if (!resource || resource->data != mc_dev) {

		dev_err(&mc_bus_dev->dev, "resource mismatch\n");

		goto out;

	}



	mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent);

	mc_bus = to_fsl_mc_bus(mc_bus_dev);

	res_pool = resource->parent_pool;

	if (res_pool != &mc_bus->resource_pools[resource->type]) {

		dev_err(&mc_bus_dev->dev, "pool mismatch\n");