Commit e0c16eb4 authored by Simon Ser's avatar Simon Ser Committed by Alex Deucher
Browse files

amdgpu: fix GEM obj leak in amdgpu_display_user_framebuffer_create 



This error code-path is missing a drm_gem_object_put call. Other
error code-paths are fine.

Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
Fixes: 1769152a ("drm/amdgpu: Fail fb creation from imported dma-bufs. (v2)")
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Harry Wentland <hwentlan@amd.com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent 8c3dd61c

drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

+1 −0
Original line number Diff line number Diff line
@@ -986,6 +986,7 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev, 
	domains = amdgpu_display_supported_domains(drm_to_adev(dev), bo->flags);

	if (obj->import_attach && !(domains & AMDGPU_GEM_DOMAIN_GTT)) {

		drm_dbg_kms(dev, "Cannot create framebuffer from imported dma_buf\n");

		drm_gem_object_put(obj);

		return ERR_PTR(-EINVAL);

	}