Commit e0ac8936 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Li Yang
Browse files

bus: fsl-mc: fsl-mc-allocator: Drop if block with always wrong condition 



If fsl_mc_is_allocatable(mc_dev) evaluates to false, the driver won't
have bound to that device and then fsl_mc_allocator_remove() is never
called for that device. fsl_mc_allocator_remove() is the only caller of
fsl_mc_resource_pool_remove_device(), so the same check can be removed
from there.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com> # sanity checks
Reviewed-by: default avatarLaurentiu Tudor <laurentiu.tudor@nxp.com>
Tested-by: default avatarLaurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: default avatarLi Yang <leoyang.li@nxp.com>
parent f8fce831

drivers/bus/fsl-mc/fsl-mc-allocator.c

+0 −6
Original line number Diff line number Diff line
@@ -103,9 +103,6 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device 
	struct fsl_mc_resource *resource;

	int error = -EINVAL;



	if (!fsl_mc_is_allocatable(mc_dev))

		goto out;



	resource = mc_dev->resource;

	if (!resource || resource->data != mc_dev)

		goto out;
@@ -613,9 +610,6 @@ static int fsl_mc_allocator_remove(struct fsl_mc_device *mc_dev) 
{

	int error;



	if (!fsl_mc_is_allocatable(mc_dev))

		return -EINVAL;



	if (mc_dev->resource) {

		error = fsl_mc_resource_pool_remove_device(mc_dev);

		if (error < 0)