Commit e0a6aad6 authored by Jamie Lentin's avatar Jamie Lentin Committed by Jiri Kosina
Browse files

HID: lenovo: Don't call function in condition, show error codes 



Signed-off-by: default avatarJamie Lentin <jm@lentin.co.uk>
Reviewed-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 6a5b414b

drivers/hid/hid-lenovo.c

+4 −4
Original line number Diff line number Diff line
@@ -350,6 +350,7 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) 
	size_t name_sz = strlen(dev_name(dev)) + 16;

	char *name_mute, *name_micmute;

	int i;

	int ret;



	/*

	 * Only register extra settings against subdevice where input_mapping
@@ -368,10 +369,9 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) 
	if (!hid_validate_values(hdev, HID_OUTPUT_REPORT, 3, 0, 2))

		return -ENODEV;



	if (sysfs_create_group(&hdev->dev.kobj,

				&lenovo_attr_group_tpkbd)) {

		hid_warn(hdev, "Could not create sysfs group\n");

	}

	ret = sysfs_create_group(&hdev->dev.kobj, &lenovo_attr_group_tpkbd);

	if (ret)

		hid_warn(hdev, "Could not create sysfs group: %d\n", ret);



	data_pointer = devm_kzalloc(&hdev->dev,

				    sizeof(struct lenovo_drvdata_tpkbd),