Commit e08cdf63 authored Dec 15, 2021 by Andrey Eremeev Committed by David S. Miller Dec 16, 2021

dsa: mv88e6xxx: fix debug print for SPEED_UNFORCED



Debug print uses invalid check to detect if speed is unforced:
(speed != SPEED_UNFORCED) should be used instead of (!speed).

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Eremeev <Axtone4all@yandex.ru>
Fixes: 96a2b40c ("net: dsa: mv88e6xxx: add port's MAC speed setter")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 407ecd1b

drivers/net/dsa/mv88e6xxx/port.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -283,7 +283,7 @@ static int mv88e6xxx_port_set_speed_duplex(struct mv88e6xxx_chip *chip,
		if (err)
		return err;

		if (speed)
		if (speed != SPEED_UNFORCED)
		dev_dbg(chip->dev, "p%d: Speed set to %d Mbps\n", port, speed);
		else
		dev_dbg(chip->dev, "p%d: Speed unforced\n", port);
		@@ -516,7 +516,7 @@ int mv88e6393x_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
		if (err)
		return err;

		if (speed)
		if (speed != SPEED_UNFORCED)
		dev_dbg(chip->dev, "p%d: Speed set to %d Mbps\n", port, speed);
		else
		dev_dbg(chip->dev, "p%d: Speed unforced\n", port);