Commit e07bf00c authored Jan 14, 2022 by Joseph Qi Committed by Linus Torvalds Jan 15, 2022

ocfs2: clearly handle ocfs2_grab_pages_for_write() return value

ocfs2_grab_pages_for_write() may return -EAGAIN if write context type is
mmap and it could not lock the target page.  In this case, we exit with
no error and no target page.  And then trigger the caller page_mkwrite()
to retry.

Since there are other caller types, e.g.  buffer and direct io, make the
return value handling more clear.

Link: https://lkml.kernel.org/r/20211206065051.103353-1-joseph.qi@linux.alibaba.com


Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Gang He <ghe@suse.com>
Cc: Jun Piao <piaojun@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 783cc68d

fs/ocfs2/aops.c

+13 −13

Original line number	Diff line number	Diff line
		@@ -1799,23 +1799,23 @@ int ocfs2_write_begin_nolock(struct address_space *mapping,
		*/
		ret = ocfs2_grab_pages_for_write(mapping, wc, wc->w_cpos, pos, len,
		cluster_of_pages, mmap_page);
		if (ret && ret != -EAGAIN) {
		mlog_errno(ret);
		goto out_quota;
		}

		if (ret) {
		/*
		* ocfs2_grab_pages_for_write() returns -EAGAIN if it could not lock
		* the target page. In this case, we exit with no error and no target
		* page. This will trigger the caller, page_mkwrite(), to re-try
		* the operation.
		*/
		if (ret == -EAGAIN) {
		if (type == OCFS2_WRITE_MMAP && ret == -EAGAIN) {
		BUG_ON(wc->w_target_page);
		ret = 0;
		goto out_quota;
		}

		mlog_errno(ret);
		goto out_quota;
		}

		ret = ocfs2_write_cluster_by_desc(mapping, data_ac, meta_ac, wc, pos,
		len);
		if (ret) {