Commit e06b5bbc authored by Jakub Sitnicki's avatar Jakub Sitnicki Committed by Daniel Borkmann
Browse files

selftests/bpf: Use constants for socket states in sock_fields test 



Replace magic numbers in BPF code with constants from bpf.h, so that they
don't require an explanation in the comments.

Signed-off-by: default avatarJakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarMartin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20220317113920.1068535-4-jakub@cloudflare.com
parent 2d2202ba

tools/testing/selftests/bpf/progs/test_sock_fields.c

+5 −5
Original line number Diff line number Diff line
@@ -134,11 +134,11 @@ int egress_read_sock_fields(struct __sk_buff *skb) 
	if (!sk)

		RET_LOG();



	/* Not the testing egress traffic or

	 * TCP_LISTEN (10) socket will be copied at the ingress side.

	/* Not testing the egress traffic or the listening socket,

	 * which are covered by the cgroup_skb/ingress test program.

	 */

	if (sk->family != AF_INET6 || !is_loopback6(sk->src_ip6) ||

	    sk->state == 10)

	    sk->state == BPF_TCP_LISTEN)

		return CG_OK;



	if (sk->src_port == bpf_ntohs(srv_sa6.sin6_port)) {
@@ -232,8 +232,8 @@ int ingress_read_sock_fields(struct __sk_buff *skb) 
	    sk->src_port != bpf_ntohs(srv_sa6.sin6_port))

		return CG_OK;



	/* Only interested in TCP_LISTEN */

	if (sk->state != 10)

	/* Only interested in the listening socket */

	if (sk->state != BPF_TCP_LISTEN)

		return CG_OK;



	/* It must be a fullsock for cgroup_skb/ingress prog */