Commit e038f7b8 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar
Browse files

cpuidle, psci: Push RCU-idle into driver 



Doing RCU-idle outside the driver, only to then temporarily enable it
again, at least twice, before going idle is suboptimal.

Notably once implicitly through the cpu_pm_*() calls and once
explicitly doing ct_irq_*_irqon().

Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Tested-by: default avatarKajetan Puchalski <kajetan.puchalski@arm.com>
Tested-by: default avatarTony Lindgren <tony@atomide.com>
Tested-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Reviewed-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Reviewed-by: default avatarGuo Ren <guoren@kernel.org>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://lore.kernel.org/r/20230112195539.760296658@infradead.org
parent 5fca0d9f

drivers/cpuidle/cpuidle-psci.c

+5 −4
Original line number Diff line number Diff line
@@ -69,12 +69,12 @@ static int __psci_enter_domain_idle_state(struct cpuidle_device *dev, 
		return -1;



	/* Do runtime PM to manage a hierarchical CPU toplogy. */

	ct_irq_enter_irqson();

	if (s2idle)

		dev_pm_genpd_suspend(pd_dev);

	else

		pm_runtime_put_sync_suspend(pd_dev);

	ct_irq_exit_irqson();



	ct_idle_enter();



	state = psci_get_domain_state();

	if (!state)
@@ -82,12 +82,12 @@ static int __psci_enter_domain_idle_state(struct cpuidle_device *dev, 


	ret = psci_cpu_suspend_enter(state) ? -1 : idx;



	ct_irq_enter_irqson();

	ct_idle_exit();



	if (s2idle)

		dev_pm_genpd_resume(pd_dev);

	else

		pm_runtime_get_sync(pd_dev);

	ct_irq_exit_irqson();



	cpu_pm_exit();
@@ -240,6 +240,7 @@ static int psci_dt_cpu_init_topology(struct cpuidle_driver *drv, 
	 * of a shared state for the domain, assumes the domain states are all

	 * deeper states.

	 */

	drv->states[state_count - 1].flags |= CPUIDLE_FLAG_RCU_IDLE;

	drv->states[state_count - 1].enter = psci_enter_domain_idle_state;

	drv->states[state_count - 1].enter_s2idle = psci_enter_s2idle_domain_idle_state;

	psci_cpuidle_use_cpuhp = true;