Commit e0138763 authored by Bastien Nocera's avatar Bastien Nocera Committed by Benjamin Tissoires
Browse files

HID: logitech-hidpp: Simplify array length check 



Use the compiler to force a 100-length array, rather than check the
length after the fact.

Signed-off-by: default avatarBastien Nocera <hadess@hadess.net>
Link: https://lore.kernel.org/r/20230302105555.51417-1-hadess@hadess.net


Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
parent 5b3691d1

drivers/hid/hid-logitech-hidpp.c

+1 −3
Original line number Diff line number Diff line
@@ -1404,7 +1404,7 @@ static int hidpp20_map_battery_capacity(struct hid_device *hid_dev, int voltage) 
	 * there are a few devices that use different battery technology.

	 */



	static const int voltages[] = {

	static const int voltages[100] = {

		4186, 4156, 4143, 4133, 4122, 4113, 4103, 4094, 4086, 4075,

		4067, 4059, 4051, 4043, 4035, 4027, 4019, 4011, 4003, 3997,

		3989, 3983, 3976, 3969, 3961, 3955, 3949, 3942, 3935, 3929,
@@ -1419,8 +1419,6 @@ static int hidpp20_map_battery_capacity(struct hid_device *hid_dev, int voltage) 


	int i;



	BUILD_BUG_ON(ARRAY_SIZE(voltages) != 100);



	if (unlikely(voltage < 3500 || voltage >= 5000))

		hid_warn_once(hid_dev,

			      "%s: possibly using the wrong voltage curve\n",