Commit e0051d7d authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Jens Axboe
Browse files

io-wq: Fix io_wq_worker_affinity() 



Do not include private headers and do not frob in internals.

On top of that, while the previous code restores the affinity, it
doesn't ensure the task actually moves there if it was running,
leading to the fun situation that it can be observed running outside
of its allowed mask for potentially significant time.

Use the proper API instead.

Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/YG7QkiUzlEbW85TU@hirez.programming.kicks-ass.net


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent cb3b200e

fs/io-wq.c

+2 −9
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ 
#include <linux/cpu.h>

#include <linux/tracehook.h>



#include "../kernel/sched/sched.h"

#include "io-wq.h"



#define WORKER_IDLE_TIMEOUT	(5 * HZ)
@@ -1064,14 +1063,8 @@ void io_wq_put_and_exit(struct io_wq *wq) 


static bool io_wq_worker_affinity(struct io_worker *worker, void *data)

{

	struct task_struct *task = worker->task;

	struct rq_flags rf;

	struct rq *rq;



	rq = task_rq_lock(task, &rf);

	do_set_cpus_allowed(task, cpumask_of_node(worker->wqe->node));

	task->flags |= PF_NO_SETAFFINITY;

	task_rq_unlock(rq, task, &rf);

	set_cpus_allowed_ptr(worker->task, cpumask_of_node(worker->wqe->node));



	return false;

}