Commit dfd0afbf authored by David Michael's avatar David Michael Committed by Daniel Borkmann
Browse files

libbpf: Fix uninitialized warning in btf_dump_dump_type_data 



GCC 11.3.0 fails to compile btf_dump.c due to the following error,
which seems to originate in btf_dump_struct_data where the returned
value would be uninitialized if btf_vlen returns zero.

btf_dump.c: In function ‘btf_dump_dump_type_data’:
btf_dump.c:2363:12: error: ‘err’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2363 |         if (err < 0)
      |            ^

Fixes: 920d16af ("libbpf: BTF dumper support for typed data")
Signed-off-by: default avatarDavid Michael <fedora.dm0@gmail.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarStanislav Fomichev <sdf@google.com>
Acked-by: default avatarAlan Maguire <alan.maguire@oracle.com>
Link: https://lore.kernel.org/bpf/87zgcu60hq.fsf@gmail.com
parent f12ed9c0

tools/lib/bpf/btf_dump.c

+1 −1
Original line number Diff line number Diff line
@@ -1989,7 +1989,7 @@ static int btf_dump_struct_data(struct btf_dump *d, 
{

	const struct btf_member *m = btf_members(t);

	__u16 n = btf_vlen(t);

	int i, err;

	int i, err = 0;



	/* note that we increment depth before calling btf_dump_print() below;

	 * this is intentional.  btf_dump_data_newline() will not print a