Commit df9c16b5 authored by Chen Jiahao's avatar Chen Jiahao Committed by Alexandre Belloni
Browse files

rtc: sunplus: Clean up redundant dev_err_probe() 



Referring to platform_get_irq()'s definition, the return value has
already been checked if ret < 0, and printed via dev_err_probe().
Calling dev_err_probe() one more time outside platform_get_irq()
is obviously redundant.

Removing dev_err_probe() outside platform_get_irq() to clean up
above problem.

Signed-off-by: default avatarChen Jiahao <chenjiahao16@huawei.com>
Link: https://lore.kernel.org/r/20230802093650.976352-1-chenjiahao16@huawei.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent a69c610e

drivers/rtc/rtc-sunplus.c

+1 −1
Original line number Diff line number Diff line
@@ -244,7 +244,7 @@ static int sp_rtc_probe(struct platform_device *plat_dev) 


	sp_rtc->irq = platform_get_irq(plat_dev, 0);

	if (sp_rtc->irq < 0)

		return dev_err_probe(&plat_dev->dev, sp_rtc->irq, "platform_get_irq failed\n");

		return sp_rtc->irq;



	ret = devm_request_irq(&plat_dev->dev, sp_rtc->irq, sp_rtc_irq_handler,

			       IRQF_TRIGGER_RISING, "rtc irq", plat_dev);