Commit df8a5cbe authored by Jithu Joseph's avatar Jithu Joseph Committed by Aichun Shi
Browse files

platform/x86/intel/ifs: Classify error scenarios correctly 

mainline inclusion
from mainline-v6.10-rc1
commit 02153e5dcb361d4a8538363362d78e3a88adf6ee
category: feature
bugzilla: https://gitee.com/openeuler/intel-kernel/issues/IASVRQ
CVE: N/A
Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=02153e5dcb361d4a8538363362d78e3a88adf6ee



-------------------------------------

"Scan controller error" means that scan hardware encountered an error
prior to doing an actual test on the target CPU. It does not mean that
there is an actual cpu/core failure. "scan signature failure" indicates
that the test result on the target core did not match the expected value
and should be treated as a cpu failure.

Current driver classifies both these scenarios as failures. Modify
the driver to classify this situation with a more appropriate "untested"
status instead of "fail" status.

Intel-SIG: commit 02153e5dcb36 platform/x86/intel/ifs: Classify error scenarios correctly
Backport to support IFS(In Field Scan) SBAF(Structural Based Functional Test at Field)

Signed-off-by: default avatarJithu Joseph <jithu.joseph@intel.com>
Reviewed-by: default avatarTony Luck <tony.luck@intel.com>
Reviewed-by: default avatarAshok Raj <ashok.raj@intel.com>
Reviewed-by: default avatarKuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Link: https://lore.kernel.org/r/20240412172349.544064-2-jithu.joseph@intel.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
[ Aichun Shi: amend commit log ]
Signed-off-by: default avatarAichun Shi <aichun.shi@intel.com>
parent 129a9ec8

drivers/platform/x86/intel/ifs/runtest.c

+15 −12
Original line number Diff line number Diff line
@@ -69,6 +69,19 @@ static const char * const scan_test_status[] = { 


static void message_not_tested(struct device *dev, int cpu, union ifs_status status)

{

	struct ifs_data *ifsd = ifs_get_data(dev);



	/*

	 * control_error is set when the microcode runs into a problem

	 * loading the image from the reserved BIOS memory, or it has

	 * been corrupted. Reloading the image may fix this issue.

	 */

	if (status.control_error) {

		dev_warn(dev, "CPU(s) %*pbl: Scan controller error. Batch: %02x version: 0x%x\n",

			 cpumask_pr_args(cpu_smt_mask(cpu)), ifsd->cur_batch, ifsd->loaded_version);

		return;

	}



	if (status.error_code < ARRAY_SIZE(scan_test_status)) {

		dev_info(dev, "CPU(s) %*pbl: SCAN operation did not start. %s\n",

			 cpumask_pr_args(cpu_smt_mask(cpu)),
@@ -90,16 +103,6 @@ static void message_fail(struct device *dev, int cpu, union ifs_status status) 
{

	struct ifs_data *ifsd = ifs_get_data(dev);



	/*

	 * control_error is set when the microcode runs into a problem

	 * loading the image from the reserved BIOS memory, or it has

	 * been corrupted. Reloading the image may fix this issue.

	 */

	if (status.control_error) {

		dev_err(dev, "CPU(s) %*pbl: could not execute from loaded scan image. Batch: %02x version: 0x%x\n",

			cpumask_pr_args(cpu_smt_mask(cpu)), ifsd->cur_batch, ifsd->loaded_version);

	}



	/*

	 * signature_error is set when the output from the scan chains does not

	 * match the expected signature. This might be a transient problem (e.g.
@@ -285,10 +288,10 @@ static void ifs_test_core(int cpu, struct device *dev) 
	/* Update status for this core */

	ifsd->scan_details = status.data;



	if (status.control_error || status.signature_error) {

	if (status.signature_error) {

		ifsd->status = SCAN_TEST_FAIL;

		message_fail(dev, cpu, status);

	} else if (status.error_code) {

	} else if (status.control_error || status.error_code) {

		ifsd->status = SCAN_NOT_TESTED;

		message_not_tested(dev, cpu, status);

	} else {