Commit df6791e7 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: iwlwifi: mvm: check link during TX 



Again, during some (botched) FW restart scenarios we can end
up with a NULL link in the driver but mac80211 thinking all
is still going OK. If we try to TX at the same time, we can
crash there. Fix that by checking for a NULL link during TX.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230614123446.cee48479deec.I4eef58f7b67afafb7b3294adbeb6e0067b68419d@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 38e72100

drivers/net/wireless/intel/iwlwifi/mvm/tx.c

+3 −1
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause

/*

 * Copyright (C) 2012-2014, 2018-2022 Intel Corporation

 * Copyright (C) 2012-2014, 2018-2023 Intel Corporation

 * Copyright (C) 2013-2015 Intel Mobile Communications GmbH

 * Copyright (C) 2016-2017 Intel Deutschland GmbH

 */
@@ -757,6 +757,8 @@ int iwl_mvm_tx_skb_non_sta(struct iwl_mvm *mvm, struct sk_buff *skb) 
			}



			link = mvmvif->link[link_id];

			if (WARN_ON(!link))

				return -1;



			if (!ieee80211_is_data(hdr->frame_control))

				sta_id = link->bcast_sta.sta_id;