Commit df6192f4 authored by Ian Kent's avatar Ian Kent Committed by Greg Kroah-Hartman
Browse files

kernfs: dont call d_splice_alias() under kernfs node lock 



The call to d_splice_alias() in kernfs_iop_lookup() doesn't depend on
any kernfs node so there's no reason to hold the kernfs node lock when
calling it.

Reviewed-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Signed-off-by: default avatarIan Kent <raven@themaw.net>
Link: https://lore.kernel.org/r/162642772000.63632.10672683419693513226.stgit@web.messagingengine.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 47b5c64d

fs/kernfs/dir.c

+2 −4
Original line number Diff line number Diff line
@@ -1100,7 +1100,6 @@ static struct dentry *kernfs_iop_lookup(struct inode *dir, 
					struct dentry *dentry,

					unsigned int flags)

{

	struct dentry *ret;

	struct kernfs_node *parent = dir->i_private;

	struct kernfs_node *kn;

	struct inode *inode = NULL;
@@ -1120,11 +1119,10 @@ static struct dentry *kernfs_iop_lookup(struct inode *dir, 
	/* Needed only for negative dentry validation */

	if (!inode)

		kernfs_set_rev(parent, dentry);

	/* instantiate and hash (possibly negative) dentry */

	ret = d_splice_alias(inode, dentry);

	up_read(&kernfs_rwsem);



	return ret;

	/* instantiate and hash (possibly negative) dentry */

	return d_splice_alias(inode, dentry);

}



static int kernfs_iop_mkdir(struct user_namespace *mnt_userns,