Unverified Commit df5b4aca authored by Jianglei Nie's avatar Jianglei Nie Committed by Mark Brown
Browse files

ASoC: qdsp6: fix potential memory leak in q6apm_get_audioreach_graph() 



q6apm_get_audioreach_graph() allocates a memory chunk for graph->graph
with audioreach_alloc_graph_pkt(). When idr_alloc() fails, graph->graph
is not released, which will lead to a memory leak.

We can release the graph->graph with kfree() when idr_alloc() fails to
fix the memory leak.

Signed-off-by: default avatarJianglei Nie <niejianglei2021@163.com>
Reviewed-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220629182520.2164409-1-niejianglei2021@163.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1c4f29ec

sound/soc/qcom/qdsp6/q6apm.c

+1 −0
Original line number Diff line number Diff line
@@ -75,6 +75,7 @@ static struct audioreach_graph *q6apm_get_audioreach_graph(struct q6apm *apm, ui 
	id = idr_alloc(&apm->graph_idr, graph, graph_id, graph_id + 1, GFP_KERNEL);

	if (id < 0) {

		dev_err(apm->dev, "Unable to allocate graph id (%d)\n", graph_id);

		kfree(graph->graph);

		kfree(graph);

		mutex_unlock(&apm->lock);

		return ERR_PTR(id);