Commit df539fc6 authored by Moshe Shemesh's avatar Moshe Shemesh Committed by Paolo Abeni
Browse files

devlink: Remove unused functions devlink_rate_leaf_create/destroy 



The previous patch removed the last usage of the functions
devlink_rate_leaf_create() and devlink_rate_nodes_destroy(). Thus,
remove these function from devlink API.

Signed-off-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent da212bd2

include/net/devlink.h

+0 −2
Original line number Diff line number Diff line
@@ -1569,8 +1569,6 @@ void devlink_port_attrs_pci_vf_set(struct devlink_port *devlink_port, u32 contro 
void devlink_port_attrs_pci_sf_set(struct devlink_port *devlink_port,

				   u32 controller, u16 pf, u32 sf,

				   bool external);

int devlink_rate_leaf_create(struct devlink_port *port, void *priv);

void devlink_rate_leaf_destroy(struct devlink_port *devlink_port);

void devlink_port_linecard_set(struct devlink_port *devlink_port,

			       struct devlink_linecard *linecard);

struct devlink_linecard *

net/core/devlink.c

+7 −35
Original line number Diff line number Diff line
@@ -10006,20 +10006,13 @@ int devl_rate_leaf_create(struct devlink_port *devlink_port, void *priv) 
}

EXPORT_SYMBOL_GPL(devl_rate_leaf_create);



int

devlink_rate_leaf_create(struct devlink_port *devlink_port, void *priv)

{

	struct devlink *devlink = devlink_port->devlink;

	int ret;



	mutex_lock(&devlink->lock);

	ret = devl_rate_leaf_create(devlink_port, priv);

	mutex_unlock(&devlink->lock);



	return ret;

}

EXPORT_SYMBOL_GPL(devlink_rate_leaf_create);



/**

 * devl_rate_leaf_destroy - destroy devlink rate leaf

 *

 * @devlink_port: devlink port linked to the rate object

 *

 * Destroy the devlink rate object of type leaf on provided @devlink_port.

 */

void devl_rate_leaf_destroy(struct devlink_port *devlink_port)

{

	struct devlink_rate *devlink_rate = devlink_port->devlink_rate;
@@ -10037,27 +10030,6 @@ void devl_rate_leaf_destroy(struct devlink_port *devlink_port) 
}

EXPORT_SYMBOL_GPL(devl_rate_leaf_destroy);



/**

 * devlink_rate_leaf_destroy - destroy devlink rate leaf

 *

 * @devlink_port: devlink port linked to the rate object

 *

 * Context: Takes and release devlink->lock <mutex>.

 */

void devlink_rate_leaf_destroy(struct devlink_port *devlink_port)

{

	struct devlink_rate *devlink_rate = devlink_port->devlink_rate;

	struct devlink *devlink = devlink_port->devlink;



	if (!devlink_rate)

		return;



	mutex_lock(&devlink->lock);

	devl_rate_leaf_destroy(devlink_port);

	mutex_unlock(&devlink->lock);

}

EXPORT_SYMBOL_GPL(devlink_rate_leaf_destroy);



/**

 * devl_rate_nodes_destroy - destroy all devlink rate nodes on device

 * @devlink: devlink instance