Commit df3d9a5b authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

tty: vt: replace _manual_ swap with swap macro in set_selection 



Make use of the swap macro instead of _manually_ swapping values
and remove unnecessary variable tmp.

This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4fbd8d19

drivers/tty/vt/selection.c

+1 −5
Original line number Diff line number Diff line
@@ -186,11 +186,7 @@ int set_selection(const struct tiocl_selection __user *sel, struct tty_struct *t 
	}



	if (ps > pe)	/* make sel_start <= sel_end */

	{

		int tmp = ps;

		ps = pe;

		pe = tmp;

	}

		swap(ps, pe);



	if (sel_cons != vc_cons[fg_console].d) {

		clear_selection();