Commit df2a4c3f authored by Tony Nguyen's avatar Tony Nguyen
Browse files

ice: Remove cppcheck suppressions 



The use of suppressions for cppcheck in the kernel does not look to be
standard as the ice driver is the only one doing it. Remove the
comments/suppressions.

Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 9d20797f

drivers/net/ethernet/intel/ice/ice_flex_pipe.c

+0 −3
Original line number Diff line number Diff line
@@ -415,7 +415,6 @@ ice_boost_tcam_handler(u32 sect_type, void *section, u32 index, u32 *offset) 
	if (sect_type != ICE_SID_RXPARSER_BOOST_TCAM)

		return NULL;



	/* cppcheck-suppress nullPointer */

	if (index > ICE_MAX_BST_TCAMS_IN_BUF)

		return NULL;
@@ -486,7 +485,6 @@ ice_label_enum_handler(u32 __always_unused sect_type, void *section, u32 index, 
	if (!section)

		return NULL;



	/* cppcheck-suppress nullPointer */

	if (index > ICE_MAX_LABELS_IN_BUF)

		return NULL;
@@ -2757,7 +2755,6 @@ ice_match_prop_lst(struct list_head *list1, struct list_head *list2) 
		count++;

	list_for_each_entry(tmp2, list2, list)

		chk_count++;

	/* cppcheck-suppress knownConditionTrueFalse */

	if (!count || count != chk_count)

		return false;

drivers/net/ethernet/intel/ice/ice_nvm.c

+0 −1
Original line number Diff line number Diff line
@@ -662,7 +662,6 @@ ice_get_orom_civd_data(struct ice_hw *hw, enum ice_bank_select bank, 


		/* Verify that the simple checksum is zero */

		for (i = 0; i < sizeof(*tmp); i++)

			/* cppcheck-suppress objectIndex */

			sum += ((u8 *)tmp)[i];



		if (sum) {

drivers/net/ethernet/intel/ice/ice_sched.c

+0 −1
Original line number Diff line number Diff line
@@ -1063,7 +1063,6 @@ ice_sched_add_nodes_to_layer(struct ice_port_info *pi, 
	*num_nodes_added = 0;

	while (*num_nodes_added < num_nodes) {

		u16 max_child_nodes, num_added = 0;

		/* cppcheck-suppress unusedVariable */

		u32 temp;



		status = ice_sched_add_nodes_to_hw_layer(pi, tc_node, parent,

drivers/net/ethernet/intel/ice/ice_txrx.c

+0 −3
Original line number Diff line number Diff line
@@ -1996,7 +1996,6 @@ int ice_tso(struct ice_tx_buf *first, struct ice_tx_offload_params *off) 
	if (err < 0)

		return err;



	/* cppcheck-suppress unreadVariable */

	protocol = vlan_get_protocol(skb);



	if (eth_p_mpls(protocol))
@@ -2033,8 +2032,6 @@ int ice_tso(struct ice_tx_buf *first, struct ice_tx_offload_params *off) 
		}



		/* reset pointers to inner headers */



		/* cppcheck-suppress unreadVariable */

		ip.hdr = skb_inner_network_header(skb);

		l4.hdr = skb_inner_transport_header(skb);