Commit df28169e authored by Dan Carpenter's avatar Dan Carpenter Committed by Felipe Balbi
Browse files

usb: gadget: Potential NULL dereference on allocation error 



The source_sink_alloc_func() function is supposed to return error
pointers on error.  The function is called from usb_get_function() which
doesn't check for NULL returns so it would result in an Oops.

Of course, in the current kernel, small allocations always succeed so
this doesn't affect runtime.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 88b1bb1f

drivers/usb/gadget/function/f_sourcesink.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -838,7 +838,7 @@ static struct usb_function *source_sink_alloc_func( 




	ss = kzalloc(sizeof(*ss), GFP_KERNEL);

	ss = kzalloc(sizeof(*ss), GFP_KERNEL);

	if (!ss)

	if (!ss)

		return NULL;

		return ERR_PTR(-ENOMEM);





	ss_opts =  container_of(fi, struct f_ss_opts, func_inst);

	ss_opts =  container_of(fi, struct f_ss_opts, func_inst);