Commit df1635a4 authored Nov 07, 2022 by Luo Meng Committed by Zheng Zengkai Nov 07, 2022

Revert "cifs: fix double free race when mount fails in cifs_get_root()"

hulk inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I5WBQA


CVE: NA

--------------------------------

This reverts commit 1f9fa07b.

Commit 2fe0e281f7ad witch merged by LTS (cifs: fix double free race
when mount fails in cifs_get_root()) fixes a double free. However,
the previous patch d17abdf7 is not merged. There is no such
issue on 5.10 because it will return after cifs_cleanup_volume_info().

Since merge this patch, cifs_cleanup_volume_info() is skipped, leading
to a memory leak.

Signed-off-by: Luo Meng <luomeng12@huawei.com>
Reviewed-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>

parent 8de1d8f4

fs/cifs/cifsfs.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -864,7 +864,6 @@ cifs_smb3_do_mount(struct file_system_type *fs_type,

		out_super:
		deactivate_locked_super(sb);
		return root;
		out:
		cifs_cleanup_volume_info(volume_info);
		return root;