Commit df119095 authored by Kemeng Shi's avatar Kemeng Shi Committed by Theodore Ts'o
Browse files

ext4: remove unnecessary exit_meta_group_info tag 



We goto exit_meta_group_info only to return -ENOMEM. Return -ENOMEM
directly instead of goto to remove this unnecessary tag.

Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: default avatarOjaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://lore.kernel.org/r/20230303172120.3800725-16-shikemeng@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 78dc9f84

fs/ext4/mballoc.c

+1 −2
Original line number Diff line number Diff line
@@ -3069,7 +3069,7 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, 
		if (meta_group_info == NULL) {

			ext4_msg(sb, KERN_ERR, "can't allocate mem "

				 "for a buddy group");

			goto exit_meta_group_info;

			return -ENOMEM;

		}

		rcu_read_lock();

		rcu_dereference(sbi->s_group_info)[idx] = meta_group_info;
@@ -3123,7 +3123,6 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, 
		group_info[idx] = NULL;

		rcu_read_unlock();

	}

exit_meta_group_info:

	return -ENOMEM;

} /* ext4_mb_add_groupinfo */