Commit df0d6f7a authored by John Efstathiades's avatar John Efstathiades Committed by David S. Miller
Browse files

lan78xx: Limit number of driver warning messages 



Device removal can result in a large burst of driver warning messages
(20 - 30) sent to the kernel log. Most of these are register read/write
failures.

This change limits the rate at which these messages are emitted.

Signed-off-by: default avatarJohn Efstathiades <john.efstathiades@pebblebay.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 77dfff5b

drivers/net/usb/lan78xx.c

+3 −2
Original line number Diff line number Diff line
@@ -462,7 +462,7 @@ static int lan78xx_read_reg(struct lan78xx_net *dev, u32 index, u32 *data) 
	if (likely(ret >= 0)) {

		le32_to_cpus(buf);

		*data = *buf;

	} else {

	} else if (net_ratelimit()) {

		netdev_warn(dev->net,

			    "Failed to read register index 0x%08x. ret = %d",

			    index, ret);
@@ -492,7 +492,8 @@ static int lan78xx_write_reg(struct lan78xx_net *dev, u32 index, u32 data) 
			      USB_VENDOR_REQUEST_WRITE_REGISTER,

			      USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,

			      0, index, buf, 4, USB_CTRL_SET_TIMEOUT);

	if (unlikely(ret < 0)) {

	if (unlikely(ret < 0) &&

	    net_ratelimit()) {

		netdev_warn(dev->net,

			    "Failed to write register index 0x%08x. ret = %d",

			    index, ret);