Commit dede33da authored by Zhu Yanjun's avatar Zhu Yanjun Committed by Jason Gunthorpe
Browse files

RDMA/irdma: Make irdma_uk_cq_init() return a void 

The function irdma_uk_cq_init always returns 0, so make it void and delete
all the return value checks.

Link: https://lore.kernel.org/r/20211019153717.3836-1-yanjun.zhu@linux.dev


Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@linux.dev>
Reviewed-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 71ee1f12

drivers/infiniband/hw/irdma/ctrl.c

+1 −4
Original line number Diff line number Diff line
@@ -2463,7 +2463,6 @@ static inline void irdma_sc_cq_ack(struct irdma_sc_cq *cq) 
enum irdma_status_code irdma_sc_cq_init(struct irdma_sc_cq *cq,

					struct irdma_cq_init_info *info)

{

	enum irdma_status_code ret_code;

	u32 pble_obj_cnt;



	pble_obj_cnt = info->dev->hmc_info->hmc_obj[IRDMA_HMC_IW_PBLE].cnt;
@@ -2475,9 +2474,7 @@ enum irdma_status_code irdma_sc_cq_init(struct irdma_sc_cq *cq, 
	cq->ceq_id = info->ceq_id;

	info->cq_uk_init_info.cqe_alloc_db = cq->dev->cq_arm_db;

	info->cq_uk_init_info.cq_ack_db = cq->dev->cq_ack_db;

	ret_code = irdma_uk_cq_init(&cq->cq_uk, &info->cq_uk_init_info);

	if (ret_code)

		return ret_code;

	irdma_uk_cq_init(&cq->cq_uk, &info->cq_uk_init_info);



	cq->virtual_map = info->virtual_map;

	cq->pbl_chunk_size = info->pbl_chunk_size;

drivers/infiniband/hw/irdma/uk.c

+2 −4
Original line number Diff line number Diff line
@@ -1446,7 +1446,7 @@ enum irdma_status_code irdma_uk_qp_init(struct irdma_qp_uk *qp, 
 * @cq: hw cq

 * @info: hw cq initialization info

 */

enum irdma_status_code irdma_uk_cq_init(struct irdma_cq_uk *cq,

void irdma_uk_cq_init(struct irdma_cq_uk *cq,

		      struct irdma_cq_uk_init_info *info)

{

	cq->cq_base = info->cq_base;
@@ -1458,8 +1458,6 @@ enum irdma_status_code irdma_uk_cq_init(struct irdma_cq_uk *cq, 
	cq->avoid_mem_cflct = info->avoid_mem_cflct;

	IRDMA_RING_INIT(cq->cq_ring, cq->cq_size);

	cq->polarity = 1;



	return 0;

}



/**

drivers/infiniband/hw/irdma/user.h

+2 −2
Original line number Diff line number Diff line
@@ -316,7 +316,7 @@ void irdma_uk_cq_request_notification(struct irdma_cq_uk *cq, 
				      enum irdma_cmpl_notify cq_notify);

void irdma_uk_cq_resize(struct irdma_cq_uk *cq, void *cq_base, int size);

void irdma_uk_cq_set_resized_cnt(struct irdma_cq_uk *qp, u16 cnt);

enum irdma_status_code irdma_uk_cq_init(struct irdma_cq_uk *cq,

void irdma_uk_cq_init(struct irdma_cq_uk *cq,

		      struct irdma_cq_uk_init_info *info);

enum irdma_status_code irdma_uk_qp_init(struct irdma_qp_uk *qp,

					struct irdma_qp_uk_init_info *info);