Unverified Commit deca1953 authored by Qiushi Wu's avatar Qiushi Wu Committed by Mark Brown
Browse files

ASoC: tegra: Fix reference count leaks. 



Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count if pm_runtime_put is not called in
error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails.

Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Reviewed-by: default avatarJon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20200613204422.24484-1-wu000273@umn.edu


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 668b1508

sound/soc/tegra/tegra30_ahub.c

+3 −1
Original line number Diff line number Diff line
@@ -643,8 +643,10 @@ static int tegra30_ahub_resume(struct device *dev) 
	int ret;



	ret = pm_runtime_get_sync(dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put(dev);

		return ret;

	}

	ret = regcache_sync(ahub->regmap_ahub);

	ret |= regcache_sync(ahub->regmap_apbif);

	pm_runtime_put(dev);

sound/soc/tegra/tegra30_i2s.c

+3 −1
Original line number Diff line number Diff line
@@ -567,8 +567,10 @@ static int tegra30_i2s_resume(struct device *dev) 
	int ret;



	ret = pm_runtime_get_sync(dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put(dev);

		return ret;

	}

	ret = regcache_sync(i2s->regmap);

	pm_runtime_put(dev);