Unverified Commit dea8e70f authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

spi: qup: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230330210341.2459548-3-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 61f49171

drivers/spi/spi-qup.c

+2 −4
Original line number Diff line number Diff line
@@ -1270,7 +1270,7 @@ static int spi_qup_resume(struct device *device) 
}

#endif /* CONFIG_PM_SLEEP */



static int spi_qup_remove(struct platform_device *pdev)

static void spi_qup_remove(struct platform_device *pdev)

{

	struct spi_master *master = dev_get_drvdata(&pdev->dev);

	struct spi_qup *controller = spi_master_get_devdata(master);
@@ -1295,8 +1295,6 @@ static int spi_qup_remove(struct platform_device *pdev) 


	pm_runtime_put_noidle(&pdev->dev);

	pm_runtime_disable(&pdev->dev);



	return 0;

}



static const struct of_device_id spi_qup_dt_match[] = {
@@ -1321,7 +1319,7 @@ static struct platform_driver spi_qup_driver = { 
		.of_match_table = spi_qup_dt_match,

	},

	.probe = spi_qup_probe,

	.remove = spi_qup_remove,

	.remove_new = spi_qup_remove,

};

module_platform_driver(spi_qup_driver);