Commit dea8464d authored by Zou Wei's avatar Zou Wei Committed by Vinod Koul
Browse files

dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe() 



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZou Wei <zou_wei@huawei.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/1622442963-54095-1-git-send-email-zou_wei@huawei.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 99b18e88

drivers/dma/sh/rcar-dmac.c

+1 −1
Original line number Diff line number Diff line
@@ -1913,7 +1913,7 @@ static int rcar_dmac_probe(struct platform_device *pdev) 


	/* Enable runtime PM and initialize the device. */

	pm_runtime_enable(&pdev->dev);

	ret = pm_runtime_get_sync(&pdev->dev);

	ret = pm_runtime_resume_and_get(&pdev->dev);

	if (ret < 0) {

		dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret);

		return ret;