Unverified Commit dea6dd2b authored by Pan Bian's avatar Pan Bian Committed by Mark Brown
Browse files

regulator: s5m8767: Fix reference count leak 



Call of_node_put() to drop references of regulators_np and reg_np before
returning error code.

Fixes: 9ae5cc75 ("regulator: s5m8767: Pass descriptor instead of GPIO number")
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20210121032756.49501-1-bianpan2016@163.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d93d6f52

drivers/regulator/s5m8767.c

+5 −2
Original line number Diff line number Diff line
@@ -573,10 +573,13 @@ static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev, 
			"s5m8767,pmic-ext-control",

			GPIOD_OUT_HIGH | GPIOD_FLAGS_BIT_NONEXCLUSIVE,

			"s5m8767");

		if (PTR_ERR(rdata->ext_control_gpiod) == -ENOENT)

		if (PTR_ERR(rdata->ext_control_gpiod) == -ENOENT) {

			rdata->ext_control_gpiod = NULL;

		else if (IS_ERR(rdata->ext_control_gpiod))

		} else if (IS_ERR(rdata->ext_control_gpiod)) {

			of_node_put(reg_np);

			of_node_put(regulators_np);

			return PTR_ERR(rdata->ext_control_gpiod);

		}



		rdata->id = i;

		rdata->initdata = of_get_regulator_init_data(