Commit de940244 authored by Rui Miguel Silva's avatar Rui Miguel Silva Committed by Greg Kroah-Hartman
Browse files

usb: isp1760: clean never read udc_enabled warning 



When CONFIG_USB_ISP1761_UDC is not enabled the udc_enabled variable is
never used since it is short circuited before in the logic operations.

This would trigger the following warning by clang analyzer:

drivers/usb/isp1760/isp1760-core.c:490:2: warning: Value stored to 'udc_enabled' is never read [clang-analyzer-deadcode.DeadStores]
        udc_enabled = ((devflags & ISP1760_FLAG_ISP1763) ||
        ^
drivers/usb/isp1760/isp1760-core.c:490:2: note: Value stored to 'udc_enabled' is never read

Just swap the other of the operands in the logic operations.

Signed-off-by: default avatarRui Miguel Silva <rui.silva@linaro.org>
Link: https://lore.kernel.org/r/20210819180929.1327349-6-rui.silva@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7d1d3882

drivers/usb/isp1760/isp1760-core.c

+2 −2
Original line number Diff line number Diff line
@@ -491,7 +491,7 @@ int isp1760_register(struct resource *mem, int irq, unsigned long irqflags, 
		       (devflags & ISP1760_FLAG_ISP1761));



	if ((!IS_ENABLED(CONFIG_USB_ISP1760_HCD) || usb_disabled()) &&

	    (!IS_ENABLED(CONFIG_USB_ISP1761_UDC) || !udc_enabled))

	    (!udc_enabled || !IS_ENABLED(CONFIG_USB_ISP1761_UDC)))

		return -ENODEV;



	isp = devm_kzalloc(dev, sizeof(*isp), GFP_KERNEL);
@@ -571,7 +571,7 @@ int isp1760_register(struct resource *mem, int irq, unsigned long irqflags, 
			return ret;

	}



	if (IS_ENABLED(CONFIG_USB_ISP1761_UDC) && udc_enabled) {

	if (udc_enabled && IS_ENABLED(CONFIG_USB_ISP1761_UDC)) {

		ret = isp1760_udc_register(isp, irq, irqflags);

		if (ret < 0) {

			isp1760_hcd_unregister(hcd);