Unverified Commit de5e92cb authored by Li Zetao's avatar Li Zetao Committed by Mark Brown
Browse files

spi: mpc5xxx-psc: Fix unsigned expression compared with zero 



There is two warnings reported by coccinelle:

./drivers/spi/spi-mpc512x-psc.c:493:5-13: WARNING:
	Unsigned expression compared with zero: mps -> irq     <     0
./drivers/spi/spi-mpc52xx-psc.c:332:5-13: WARNING:
	Unsigned expression compared with zero: mps -> irq     <     0

The commit "208ee586"
("spi: mpc5xxx-psc: Return immediately if IRQ resource is unavailable")
was to check whether the IRQ resource is unavailable. When the IRQ
resource is unavailable, an error code is returned, however, the type
of "mps->irq" is "unsigned int", causing the error code to flip. Modify
the type of "mps->irq" to solve this problem.

Fixes: 208ee586 ("spi: mpc5xxx-psc: Return immediately if IRQ resource is unavailable")
Signed-off-by: default avatarLi Zetao <lizetao1@huawei.com>
Link: https://lore.kernel.org/r/20230803134805.1037251-1-lizetao1@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d8736266

drivers/spi/spi-mpc512x-psc.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -53,7 +53,7 @@ struct mpc512x_psc_spi { 
	int type;

	int type;

	void __iomem *psc;

	void __iomem *psc;

	struct mpc512x_psc_fifo __iomem *fifo;

	struct mpc512x_psc_fifo __iomem *fifo;

	unsigned int irq;

	int irq;

	u8 bits_per_word;

	u8 bits_per_word;

	u32 mclk_rate;

	u32 mclk_rate;