Commit de5e2b36 authored by Al Viro's avatar Al Viro
Browse files

hpfs: endianness bugs 



a couple of le32 and le16 used with wrong le..._to_cpu(), plus
idiotic use of le32_to_cpu() on 1-bit bitfield

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 528c0327

fs/hpfs/ea.c

+1 −1
Original line number Diff line number Diff line
@@ -246,7 +246,7 @@ void hpfs_set_ea(struct inode *inode, struct fnode *fnode, const char *key, 
	if (le16_to_cpu(fnode->ea_offs) < 0xc4 || le16_to_cpu(fnode->ea_offs) + le16_to_cpu(fnode->acl_size_s) + le16_to_cpu(fnode->ea_size_s) > 0x200) {

		hpfs_error(s, "fnode %08lx: ea_offs == %03x, ea_size_s == %03x",

			(unsigned long)inode->i_ino,

			le32_to_cpu(fnode->ea_offs), le16_to_cpu(fnode->ea_size_s));

			le16_to_cpu(fnode->ea_offs), le16_to_cpu(fnode->ea_size_s));

		return;

	}

	if ((le16_to_cpu(fnode->ea_size_s) || !le32_to_cpu(fnode->ea_size_l)) &&

fs/hpfs/super.c

+2 −2
Original line number Diff line number Diff line
@@ -572,7 +572,7 @@ static int hpfs_fill_super(struct super_block *s, void *options, int silent) 
		mark_buffer_dirty(bh2);

	}



	if (le32_to_cpu(spareblock->hotfixes_used) || le32_to_cpu(spareblock->n_spares_used)) {

	if (spareblock->hotfixes_used || le32_to_cpu(spareblock->n_spares_used)) {

		if (errs >= 2) {

			printk("HPFS: Hotfixes not supported here, try chkdsk\n");

			mark_dirty(s, 0);
@@ -645,7 +645,7 @@ static int hpfs_fill_super(struct super_block *s, void *options, int silent) 
		root->i_mtime.tv_nsec = 0;

		root->i_ctime.tv_sec = local_to_gmt(s, le32_to_cpu(de->creation_date));

		root->i_ctime.tv_nsec = 0;

		hpfs_i(root)->i_ea_size = le16_to_cpu(de->ea_size);

		hpfs_i(root)->i_ea_size = le32_to_cpu(de->ea_size);

		hpfs_i(root)->i_parent_dir = root->i_ino;

		if (root->i_size == -1)

			root->i_size = 2048;