Commit de52e173 authored by Fedor Pchelkin's avatar Fedor Pchelkin Committed by Paolo Abeni
Browse files

tipc: stop tipc crypto on failure in tipc_node_create 



If tipc_link_bc_create() fails inside tipc_node_create() for a newly
allocated tipc node then we should stop its tipc crypto and free the
resources allocated with a call to tipc_crypto_start().

As the node ref is initialized to one to that point, just put the ref on
tipc_link_bc_create() error case that would lead to tipc_node_free() be
eventually executed and properly clean the node and its crypto resources.

Found by Linux Verification Center (linuxtesting.org).

Fixes: cb8092d7 ("tipc: move bc link creation back to tipc_node_create")
Suggested-by: default avatarXin Long <lucien.xin@gmail.com>
Signed-off-by: default avatarFedor Pchelkin <pchelkin@ispras.ru>
Reviewed-by: default avatarXin Long <lucien.xin@gmail.com>
Link: https://lore.kernel.org/r/20230725214628.25246-1-pchelkin@ispras.ru


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent ecb4534b

net/tipc/node.c

+1 −1
Original line number Diff line number Diff line
@@ -583,7 +583,7 @@ struct tipc_node *tipc_node_create(struct net *net, u32 addr, u8 *peer_id, 
				 n->capabilities, &n->bc_entry.inputq1,

				 &n->bc_entry.namedq, snd_l, &n->bc_entry.link)) {

		pr_warn("Broadcast rcv link creation failed, no memory\n");

		kfree(n);

		tipc_node_put(n);

		n = NULL;

		goto exit;

	}