Commit de416a9f authored by Yang Li's avatar Yang Li Committed by Lee Jones
Browse files

leds: cht-wcove: Fix an unsigned comparison which can never be negative 



The return value from the call to cht_wc_leds_find_freq() is int.
However, the return value is being assigned to an unsigned
int variable 'ctrl', so making it an int.

Eliminate the following warning:
drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341


Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230531020238.102684-1-yang.lee@linux.alibaba.com
parent 3f80ba44

drivers/leds/leds-cht-wcove.c

+1 −2
Original line number Diff line number Diff line
@@ -223,8 +223,7 @@ static int cht_wc_leds_set_effect(struct led_classdev *cdev, 
				  u8 effect)

{

	struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);

	unsigned int ctrl;

	int ret;

	int ctrl, ret;



	mutex_lock(&led->mutex);