Commit dde41a69 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

net: dsa: mv88e6xxx: Fix off by in one in mv88e6185_phylink_get_caps() 



The <= ARRAY_SIZE() needs to be < ARRAY_SIZE() to prevent an out of
bounds error.

Fixes: d4ebf12b ("net: dsa: mv88e6xxx: populate supported_interfaces and mac_capabilities")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 87a9b2fd

drivers/net/dsa/mv88e6xxx/chip.c

+1 −1
Original line number Diff line number Diff line
@@ -585,7 +585,7 @@ static void mv88e6185_phylink_get_caps(struct mv88e6xxx_chip *chip, int port, 
{

	u8 cmode = chip->ports[port].cmode;



	if (cmode <= ARRAY_SIZE(mv88e6185_phy_interface_modes) &&

	if (cmode < ARRAY_SIZE(mv88e6185_phy_interface_modes) &&

	    mv88e6185_phy_interface_modes[cmode])

		__set_bit(mv88e6185_phy_interface_modes[cmode],

			  config->supported_interfaces);