Commit dd804694 authored by Junxian Huang's avatar Junxian Huang Committed by zhangyuyang
Browse files

RDMA/hns: Optimize hem allocation performance 

maillist inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAR316
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=fe51f6254d81f5a69c31df16353d6539b2b51630



----------------------------------------------------------------------

When allocating MTT hem, for each hop level of each hem that is being
allocated, the driver iterates the hem list to find out whether the
bt page has been allocated in this hop level. If not, allocate a new
one and splice it to the list. The time complexity is O(n^2) in worst
cases.

Currently the allocation for-loop uses 'unit' as the step size. This
actually has taken into account the reuse of last-hop-level MTT bt
pages by multiple buffer pages. Thus pages of last hop level will
never have been allocated, so there is no need to iterate the hem list
in last hop level.

Removing this unnecessary iteration can reduce the time complexity to
O(n).

Fixes: 38389eaa ("RDMA/hns: Add mtr support for mixed multihop addressing")
Signed-off-by: default avatarJunxian Huang <huangjunxian6@hisilicon.com>
Link: https://patch.msgid.link/20240906093444.3571619-9-huangjunxian6@hisilicon.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarXinghai Cen <cenxinghai@h-partners.com>
parent 876c527e

drivers/infiniband/hw/hns/hns_roce_hem.c

+6 −4
Original line number Diff line number Diff line
@@ -1135,11 +1135,13 @@ static int hem_list_alloc_mid_bt(struct hns_roce_dev *hr_dev, 


	/* config L1 bt to last bt and link them to corresponding parent */

	for (level = 1; level < hopnum; level++) {

		if (!hem_list_is_bottom_bt(hopnum, level)) {

			cur = hem_list_search_item(&mid_bt[level], offset);

			if (cur) {

				hem_ptrs[level] = cur;

				continue;

			}

		}



		step = hem_list_calc_ba_range(hopnum, level, unit);

		if (step < 1) {