Commit dd72fadf authored by Ayush Sawal's avatar Ayush Sawal Committed by Steffen Klassert
Browse files

xfrm: Fix xfrm offload fallback fail case 



In case of xfrm offload, if xdo_dev_state_add() of driver returns
-EOPNOTSUPP, xfrm offload fallback is failed.
In xfrm state_add() both xso->dev and xso->real_dev are initialized to
dev and when err(-EOPNOTSUPP) is returned only xso->dev is set to null.

So in this scenario the condition in func validate_xmit_xfrm(),
if ((x->xso.dev != dev) && (x->xso.real_dev == dev))
                return skb;
returns true, due to which skb is returned without calling esp_xmit()
below which has fallback code. Hence the CRYPTO_FALLBACK is failing.

So fixing this with by keeping x->xso.real_dev as NULL when err is
returned in func xfrm_dev_state_add().

Fixes: bdfd2d1f ("bonding/xfrm: use real_dev instead of slave_dev")
Signed-off-by: default avatarAyush Sawal <ayush.sawal@chelsio.com>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent 6fd06963

net/xfrm/xfrm_device.c

+1 −0
Original line number Diff line number Diff line
@@ -268,6 +268,7 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x, 
		xso->num_exthdrs = 0;

		xso->flags = 0;

		xso->dev = NULL;

		xso->real_dev = NULL;

		dev_put(dev);



		if (err != -EOPNOTSUPP)