Commit dd65a243 authored by Shuah Khan's avatar Shuah Khan Committed by Greg Kroah-Hartman
Browse files

usb/usbip: Fix v_recv_cmd_submit() to use PIPE_BULK define 



Fix v_recv_cmd_submit() to use PIPE_BULK define instead of hard coded
values. This also fixes the following signed integer overflow error
reported by cppcheck. This is not an issue since pipe is unsigned int.
However, this change improves the code to use proper define.

drivers/usb/usbip/vudc_rx.c:152:26: error: Signed integer overflow for expression '3<<30'. [integerOverflow]
 urb_p->urb->pipe &= ~(3 << 30);

In addition, add a build time check for PIPE_BULK != 3 as the code path
depends on PIPE_BULK = 3.

Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20221110194738.38514-1-skhan@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8836402d

drivers/usb/usbip/vudc_rx.c

+3 −1
Original line number Diff line number Diff line
@@ -149,7 +149,9 @@ static int v_recv_cmd_submit(struct vudc *udc, 
	urb_p->urb->status = -EINPROGRESS;



	/* FIXME: more pipe setup to please usbip_common */

	urb_p->urb->pipe &= ~(3 << 30);

	BUILD_BUG_ON_MSG(PIPE_BULK != 3, "PIPE_* doesn't range from 0 to 3");



	urb_p->urb->pipe &= ~(PIPE_BULK << 30);

	switch (urb_p->ep->type) {

	case USB_ENDPOINT_XFER_BULK:

		urb_p->urb->pipe |= (PIPE_BULK << 30);