Commit dd5a927e authored by Amir Goldstein's avatar Amir Goldstein Committed by Steve French
Browse files

cifs: fix set of group SID via NTSD xattrs 



'setcifsacl -g <SID>' silently fails to set the group SID on server.

Actually, the bug existed since commit 438471b6 ("CIFS: Add support
for setting owner info, dos attributes, and create time"), but this fix
will not apply cleanly to kernel versions <= v5.10.

Fixes: 3970acf7 ("SMB3: Add support for getting and setting SACLs")
Cc: stable@vger.kernel.org # 5.11+
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 9405b5f8

fs/cifs/xattr.c

+2 −0
Original line number Diff line number Diff line
@@ -175,11 +175,13 @@ static int cifs_xattr_set(const struct xattr_handler *handler, 
				switch (handler->flags) {

				case XATTR_CIFS_NTSD_FULL:

					aclflags = (CIFS_ACL_OWNER |

						    CIFS_ACL_GROUP |

						    CIFS_ACL_DACL |

						    CIFS_ACL_SACL);

					break;

				case XATTR_CIFS_NTSD:

					aclflags = (CIFS_ACL_OWNER |

						    CIFS_ACL_GROUP |

						    CIFS_ACL_DACL);

					break;

				case XATTR_CIFS_ACL: