Commit dd2ac1d6 authored by Zijun Hu's avatar Zijun Hu Committed by Marcel Holtmann
Browse files

Bluetooth: hci_h4: Fix padding calculation error within h4_recv_buf() 



it is erroneous to calculate padding by subtracting length of type
indication from skb->len, it will cause data analysis error for
alignment which is greater than 1, so fixed by adding length of type
indication with skb->len.

Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 258f56d1

drivers/bluetooth/hci_h4.c

+2 −2
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb, 
			}



			if (!dlen) {

				hu->padding = (skb->len - 1) % alignment;

				hu->padding = (skb->len + 1) % alignment;

				hu->padding = (alignment - hu->padding) % alignment;



				/* No more data, complete frame */
@@ -260,7 +260,7 @@ struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb, 
				skb = NULL;

			}

		} else {

			hu->padding = (skb->len - 1) % alignment;

			hu->padding = (skb->len + 1) % alignment;

			hu->padding = (alignment - hu->padding) % alignment;



			/* Complete frame */