Unverified Commit dccd6d84 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!13308 ext4: don't set SB_RDONLY after filesystem errors 

Merge Pull Request from: @ci-robot 
 
PR sync from: Yongjian Sun <sunyongjian1@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/PYE3PKB47PIQEL53ZXPT5VRM4ELUMJSR/ 
 
https://gitee.com/src-openeuler/kernel/issues/IB2YWS 
 
Link:https://gitee.com/openeuler/kernel/pulls/13308

 

Reviewed-by: default avatarZhang Peng <zhangpeng362@huawei.com>
Signed-off-by: default avatarZhang Peng <zhangpeng362@huawei.com>
parents 7161eccc 88a5f8ce

fs/ext4/super.c

+5 −4
Original line number Diff line number Diff line
@@ -821,11 +821,12 @@ static void ext4_handle_error(struct super_block *sb, bool force_ro, int error, 


	ext4_msg(sb, KERN_CRIT, "Remounting filesystem read-only");

	/*

	 * Make sure updated value of ->s_mount_flags will be visible before

	 * ->s_flags update

	 * EXT4_FLAGS_SHUTDOWN was set which stops all filesystem

	 * modifications. We don't set SB_RDONLY because that requires

	 * sb->s_umount semaphore and setting it without proper remount

	 * procedure is confusing code such as freeze_super() leading to

	 * deadlocks and other problems.

	 */

	smp_wmb();

	sb->s_flags |= SB_RDONLY;

#ifdef CONFIG_EXT4_ERROR_REPORT

out:

	ext4_netlink_send_info(sb, force_ro ? 2 : 1);