Commit dcc14cfd authored by Wang Hai's avatar Wang Hai Committed by David S. Miller
Browse files

net/9p: Fix a potential socket leak in p9_socket_open 



Both p9_fd_create_tcp() and p9_fd_create_unix() will call
p9_socket_open(). If the creation of p9_trans_fd fails,
p9_fd_create_tcp() and p9_fd_create_unix() will return an
error directly instead of releasing the cscoket, which will
result in a socket leak.

This patch adds sock_release() to fix the leak issue.

Fixes: 6b18662e ("9p connect fixes")
Signed-off-by: default avatarWang Hai <wanghai38@huawei.com>
ACKed-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b8f79dcc

net/9p/trans_fd.c

+3 −1
Original line number Diff line number Diff line
@@ -860,8 +860,10 @@ static int p9_socket_open(struct p9_client *client, struct socket *csocket) 
	struct file *file;



	p = kzalloc(sizeof(struct p9_trans_fd), GFP_KERNEL);

	if (!p)

	if (!p) {

		sock_release(csocket);

		return -ENOMEM;

	}



	csocket->sk->sk_allocation = GFP_NOIO;

	file = sock_alloc_file(csocket, 0, NULL);