Commit dcbfef82 authored by roel kluin's avatar roel kluin Committed by David S. Miller
Browse files

au1000_eth: possible NULL dereference of aup->mii_bus->irq in au1000_probe() 



aup->mii_bus->irq allocation may fail, prevent a dereference of NULL.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Acked-by: default avatarFlorian Fainelli <florian@openwrt.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5d789229

drivers/net/au1000_eth.c

+3 −0
Original line number Diff line number Diff line
@@ -1157,6 +1157,9 @@ static struct net_device * au1000_probe(int port_num) 
	aup->mii_bus->name = "au1000_eth_mii";

	snprintf(aup->mii_bus->id, MII_BUS_ID_SIZE, "%x", aup->mac_id);

	aup->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL);

	if (aup->mii_bus->irq == NULL)

		goto err_out;



	for(i = 0; i < PHY_MAX_ADDR; ++i)

		aup->mii_bus->irq[i] = PHY_POLL;