Commit dcb83f6e authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

genirq/msi: Rename IRQ_DOMAIN_MSI_REMAP to IRQ_DOMAIN_ISOLATED_MSI 

What x86 calls "interrupt remapping" is one way to achieve isolated MSI,
make it clear this is talking about isolated MSI, no matter how it is
achieved. This matches the new driver facing API name of
msi_device_has_isolated_msi()

No functional change.

Link: https://lore.kernel.org/r/6-v3-3313bb5dd3a3+10f11-secure_msi_jgg@nvidia.com


Tested-by: default avatarMatthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent a5e72a6b

drivers/irqchip/irq-gic-v3-its.c

+2 −2
Original line number Diff line number Diff line
@@ -4692,7 +4692,7 @@ static bool __maybe_unused its_enable_quirk_socionext_synquacer(void *data) 
		}



		/* the pre-ITS breaks isolation, so disable MSI remapping */

		its->msi_domain_flags &= ~IRQ_DOMAIN_FLAG_MSI_REMAP;

		its->msi_domain_flags &= ~IRQ_DOMAIN_FLAG_ISOLATED_MSI;

		return true;

	}

	return false;
@@ -5074,7 +5074,7 @@ static int __init its_probe_one(struct resource *res, 
	its->cmd_write = its->cmd_base;

	its->fwnode_handle = handle;

	its->get_msi_base = its_irq_get_msi_base;

	its->msi_domain_flags = IRQ_DOMAIN_FLAG_MSI_REMAP;

	its->msi_domain_flags = IRQ_DOMAIN_FLAG_ISOLATED_MSI;



	its_enable_quirks(its);

include/linux/irqdomain.h

+4 −2
Original line number Diff line number Diff line
@@ -192,8 +192,10 @@ enum { 
	/* Irq domain implements MSIs */

	IRQ_DOMAIN_FLAG_MSI		= (1 << 4),



	/* Irq domain implements MSI remapping */

	IRQ_DOMAIN_FLAG_MSI_REMAP	= (1 << 5),

	/*

	 * Irq domain implements isolated MSI, see msi_device_has_isolated_msi()

	 */

	IRQ_DOMAIN_FLAG_ISOLATED_MSI	= (1 << 5),



	/* Irq domain doesn't translate anything */

	IRQ_DOMAIN_FLAG_NO_MAP		= (1 << 6),

kernel/irq/msi.c

+1 −1
Original line number Diff line number Diff line
@@ -1645,7 +1645,7 @@ bool msi_device_has_isolated_msi(struct device *dev) 
	struct irq_domain *domain = dev_get_msi_domain(dev);



	for (; domain; domain = domain->parent)

		if (domain->flags & IRQ_DOMAIN_FLAG_MSI_REMAP)

		if (domain->flags & IRQ_DOMAIN_FLAG_ISOLATED_MSI)

			return true;

	return false;

}